[webkit-reviews] review granted: [Bug 128125] Refine MediaSession interruptions : [Attachment 223024] Proposed patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 128125: Refine MediaSession interruptions
https://bugs.webkit.org/show_bug.cgi?id=128125

Attachment 223024: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=223024&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223024&action=review


Nice stuff! r=me with just a couple of nits:

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:124
> +    [center addObserver:self
selector:@selector(applicationWillEnterForeground:)
name:UIApplicationWillEnterForegroundNotification object:nil];
> +    [center addObserver:self
selector:@selector(applicationWillResignActive:)
name:UIApplicationWillResignActiveNotification object:nil];
> +

Nit: this isn't going to work in WK2 mode.  We'll need to pipe a notification
down through the process boundary in that case.  We should probably add a FIXME
to come up with an alternate mechanism.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:140
> +- (void)interruption:(NSNotification *)notification
> +{

Did you mean to get rid of the "if (!_callback)" check here? The prettydiff is
a bit confusing.