[webkit-reviews] review granted: [Bug 128116] Manage RuleSet and RuleData classes through std::unique_ptr instead of OwnPtr : [Attachment 223010] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 3 14:59:45 PST 2014
Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128116: Manage RuleSet and RuleData classes through std::unique_ptr instead
of OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=128116
Attachment 223010: Patch
https://bugs.webkit.org/attachment.cgi?id=223010&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223010&action=review
> Source/WebCore/css/CSSDefaultStyleSheets.cpp:111
> + defaultStyle = std::make_unique<RuleSet>().release();
> + defaultPrintStyle = std::make_unique<RuleSet>().release();
I know that Anders likes this, but I think it’s pretty strange to write a plain
old “new” this way.
More information about the webkit-reviews
mailing list