[webkit-reviews] review granted: [Bug 128126] Deconstructed parameters aren't being placed in the correct scope : [Attachment 223019] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 3 14:40:38 PST 2014
Antti Koivisto <koivisto at iki.fi> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 128126: Deconstructed parameters aren't being placed in the correct scope
https://bugs.webkit.org/show_bug.cgi?id=128126
Attachment 223019: Patch
https://bugs.webkit.org/attachment.cgi?id=223019&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=223019&action=review
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:67
> + for (size_t i = 0; i < m_deconstructedParameters.size(); i++) {
> + auto& entry = m_deconstructedParameters[i];
I would use range-for here and elsewhere.
More information about the webkit-reviews
mailing list