[webkit-reviews] review granted: [Bug 128050] Keep only captured symbols in CodeBlock symbol tables. : [Attachment 222890] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 3 12:06:36 PST 2014
Geoffrey Garen <ggaren at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 128050: Keep only captured symbols in CodeBlock symbol tables.
https://bugs.webkit.org/show_bug.cgi?id=128050
Attachment 222890: Patch
https://bugs.webkit.org/attachment.cgi?id=222890&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me because this patch is better than the status quo.
I think it would be even better to make a new SymbolTable, and just copy the
captured things into it. (In the common case, nothing will be captured, so that
will be faster.)
More information about the webkit-reviews
mailing list