[webkit-reviews] review granted: [Bug 128114] AX: WebKit should support @headers/@id for complex accessible web tables : [Attachment 223001] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 128114: AX: WebKit should support @headers/@id for complex accessible web
tables
https://bugs.webkit.org/show_bug.cgi?id=128114

Attachment 223001: patch 
https://bugs.webkit.org/attachment.cgi?id=223001&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review


> Source/WebCore/accessibility/AccessibilityTableCell.cpp:158
> +	   AccessibilityObject* object = cache->getOrCreate(element);
> +	   if (object)
> +	       headers.append(object);

I suggest putting this inside the if statement.

    if (AccessibilityObject* object = cache->getOrCreate(element))
	headers.append(object);

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:162
> +    if (headers.size())

Maybe !headers.isEmpty() would be better?