[webkit-reviews] review granted: [Bug 128077] WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when iteration fails to load with HTTP 401 status code : [Attachment 222995] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 128077: WebKit Bot Watcher's Dashboard: Defer subsequent resource loads
from access-restricted build bot when iteration fails to load with HTTP 401
status code
https://bugs.webkit.org/show_bug.cgi?id=128077

Attachment 222995: Patch
https://bugs.webkit.org/attachment.cgi?id=222995&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222995&action=review


> Tools/ChangeLog:12
> +	   HTTP credentials for an iteration so long as an earlier
authentication request wasn't cancelled
> +	   (i.e. failed with an HTTP 401 Unauthorized status code). Currently
an authentication dialog will be
> +	   presented for an iteration each time the update queue timer fires
until a person successfully

I think that this would be easier to understand if it said "credentials for the
buildbot" not "credentials for am iteration".