[webkit-reviews] review granted: [Bug 128098] Stop using PLATFORM(MAC)=?UTF-8?Q?=20in=20JavaScriptCore=20except=20where=20it=20means=20=E2=80=9COS=20X=20but=20not=20iOS=E2=80=9D=20?=: [Attachment 222964] Replace PLATFORM(MAC) with alternatives appropriate for the context
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 3 00:09:05 PST 2014
Darin Adler <darin at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 128098: Stop using PLATFORM(MAC) in JavaScriptCore except where it means
“OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128098
Attachment 222964: Replace PLATFORM(MAC) with alternatives appropriate for the
context
https://bugs.webkit.org/attachment.cgi?id=222964&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222964&action=review
> Source/JavaScriptCore/runtime/Watchdog.h:29
> +#if OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK)
I probably would have guarded this just by OS(DARWIN) even though the actual
code is turned off for EFL and GTK.
More information about the webkit-reviews
mailing list