[webkit-reviews] review granted: [Bug 128084] WK2: Selection in non editable content is not cleared when navigating to a different page : [Attachment 222941] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 2 15:26:42 PST 2014


mitz at webkit.org <mitz at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 128084: WK2: Selection in non editable content is not cleared when
navigating to a different page
https://bugs.webkit.org/show_bug.cgi?id=128084

Attachment 222941: Patch
https://bugs.webkit.org/attachment.cgi?id=222941&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
Conceptually it seems wrong to do any work in our override of
resignFirstResponder if the superclass implementation is going to return NO.
Should we call super first and bail out if it returned NO?

This is not new to this patch, however, so r=me.


More information about the webkit-reviews mailing list