[webkit-reviews] review granted: [Bug 128067] Adopt URLUtils interface and template in HTMLAnchorElement and HTMLAreaElement : [Attachment 222929] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 2 13:44:47 PST 2014


Antti Koivisto <koivisto at iki.fi> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 128067: Adopt URLUtils interface and template in HTMLAnchorElement and
HTMLAreaElement
https://bugs.webkit.org/show_bug.cgi?id=128067

Attachment 222929: Patch
https://bugs.webkit.org/attachment.cgi?id=222929&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=222929&action=review


Looks good except for the strange test change.

>> Source/WebCore/html/HTMLAnchorElement.h:66
>> +	void setHref(const AtomicString& value, ExceptionCode&) {
setHref(value); }
> 
> Is it valid to call this in a manner that throws an exception? If not,
shouldn’t we just use the ASSERT_NO_EXCEPTION mechanism?

If argument-free version is for internal use only and not part of the DOM then
it is much better to keep it separate rather than uglify our code with
ASSERT_NO_EXCEPTION.


More information about the webkit-reviews mailing list