[webkit-reviews] review granted: [Bug 128056] Subpixel rendering: LayoutUnit operator++ is broken. : [Attachment 222899] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 128056: Subpixel rendering: LayoutUnit operator++ is broken.
https://bugs.webkit.org/show_bug.cgi?id=128056

Attachment 222899: Patch
https://bugs.webkit.org/attachment.cgi?id=222899&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222899&action=review


> Source/WebCore/platform/LayoutUnit.h:197
> -    LayoutUnit operator++(int)
> +    LayoutUnit& operator++()
>      {
>	   m_value += kEffectiveFixedPointDenominator;
>	   return *this;
>      }

Great fix!

> Source/WebCore/platform/LayoutUnit.h:204
> +    LayoutUnit operator++(int)
> +    {
> +	   LayoutUnit result = *this;
> +	   ++(*this);
> +	   return result;
> +    }

Not sure we really need to add this, although I suppose it does little harm.

On a separate note, if it was me I would have written ++*this without
parentheses.