[webkit-reviews] review granted: [Bug 128042] Use deprecatedCharacters in a few more places (non-Mac-build sites found by EWS) : [Attachment 222882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 1 16:08:09 PST 2014


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 128042: Use deprecatedCharacters in a few more places (non-Mac-build sites
found by EWS)
https://bugs.webkit.org/show_bug.cgi?id=128042

Attachment 222882: Patch
https://bugs.webkit.org/attachment.cgi?id=222882&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222882&action=review


> Source/WebCore/platform/win/BString.cpp:84
> +	   m_bstr = SysAllocStringLen(s.deprecatedCharacters(), s.length());

AtomicString does not have a deprecatedCharacters(), so you need to do a
s.string().deprecatedCharacters().


More information about the webkit-reviews mailing list