[webkit-reviews] review granted: [Bug 127880] IDB: Implement IDBObjectStore.delete() : [Attachment 222888] Patch v1

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 127880: IDB: Implement IDBObjectStore.delete()
https://bugs.webkit.org/show_bug.cgi?id=127880

Attachment 222888: Patch v1
https://bugs.webkit.org/attachment.cgi?id=222888&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222888&action=review


>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:880
> +    keys.append(cursor->currentKey());
> +    while (cursor->advance(1))
> +	   keys.append(cursor->currentKey());

This could probably be a do { } while() loop.

>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:892
> +    for (auto key : keys) {

This will probably copy each key, which is not what you want.  Instead use, for
(auto& key : keys)