[webkit-reviews] review granted: [Bug 136402] Simplify DOMTimer::adjustMinimumTimerInterval -> updateTimerIntervalIfNecessary : [Attachment 237403] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 19:50:34 PDT 2014


Andreas Kling <akling at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 136402: Simplify DOMTimer::adjustMinimumTimerInterval ->
updateTimerIntervalIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=136402

Attachment 237403: Fix
https://bugs.webkit.org/attachment.cgi?id=237403&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237403&action=review


r=me

> Source/WebCore/ChangeLog:9
> +	   Updating the fire/repeat internal on TimerBase requires a delta, but
in

internal -> interval

> Source/WebCore/ChangeLog:12
> +	   but in the case of one-shot timers neither TimerBase no DOMTimer
have store the interval

no -> nor


More information about the webkit-reviews mailing list