[webkit-reviews] review granted: [Bug 136386] Update webkit dashboard to support performance bots : [Attachment 237383] Implementation to display performance bots on the dashboard

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Dana Burkart
<dburkart at apple.com>'s request for review:
Bug 136386: Update webkit dashboard to support performance bots
https://bugs.webkit.org/show_bug.cgi?id=136386

Attachment 237383: Implementation to display performance bots on the dashboard
https://bugs.webkit.org/attachment.cgi?id=237383&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237383&action=review


Overall this looks fine, although it looks like adding the concept of perf bots
doesn't quite fit into the assumptions about debug and release builds (based on
some of the if statements added).  I don't think that should stop us from
landing this change, though.

r=me, but I'd prefer it if someone more familiar with the code looked at it,
too.  (I CCed some folks.)

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/W
ebKitBuildbot.js:54
> +	   "EFL Linux 64-bit Release WK2": {platform:
Dashboard.Platform.LinuxEFL, tester: true, testCategory:
Buildbot.TestCategory.WebKit2},
> +	   "EFL Linux 64-bit Release WK2 (Perf)": {platform:
Dashboard.Platform.LinuxEFL, tester: true, testCategory:
Buildbot.TestCategory.Performance}

These seem unrelated to the patch (although I suppose it's okay to add them now
while you're in the neighborhood).