[webkit-reviews] review denied: [Bug 136391] ASSERTION FAILED: cell->isObject() in JSC::asObject(JSCell*) : [Attachment 237381] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 15:38:49 PDT 2014


Michael Saboff <msaboff at apple.com> has denied Akos Kiss
<akiss at inf.u-szeged.hu>'s request for review:
Bug 136391: ASSERTION FAILED: cell->isObject() in JSC::asObject(JSCell*)
https://bugs.webkit.org/show_bug.cgi?id=136391

Attachment 237381: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=237381&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
r-

This should only be needed for calls from vmEntryToNative to native code.  Move
the "storep cfr, [sp]" outside of the various if block to always happen in the
makeHostFunctionCall macros in both LowLevelInterpreter{32_64,64}.asm


More information about the webkit-reviews mailing list