[webkit-reviews] review granted: [Bug 136388] [iOS] Configure Xcode to build a command line tool for the iOS Simulator : [Attachment 237380] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 136388: [iOS] Configure Xcode to build a command line tool for the iOS
Simulator
https://bugs.webkit.org/show_bug.cgi?id=136388

Attachment 237380: Patch
https://bugs.webkit.org/attachment.cgi?id=237380&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237380&action=review


r=me

> Tools/ChangeLog:9
> +	   Add a script, called
configure-Xcode-to-build-iOS-Simulator-command-line-tool, to
> +	   configure Xcode to support building a command line tool for the iOS
Simulator.

We could be a little less specific about the script name so it could be
shorter:  configure-Xcode-for-iOS-Simulator-builds

Not required if there are no other objections.

> Tools/ChangeLog:16
> +	   Additionally, teach build-{jsc, webkit} to call the script when
building for
> +	   iOS Simulator.

How much does this slow down build-webkit?

While it's great that we can make this transparent to the user, don't they need
to be root to run the script?  I always envisioned this as a one-time script
(after installing Xcode) that each developer would have to run, although there
is value in making builds "just work".	:)

> Tools/Scripts/configure-Xcode-to-build-iOS-Simulator-command-line-tool:52
> +    if ($file =~ /^\../) {

Won't this ignore "."?	Maybe that doesn't matter because it gets filtered out
below.

> Tools/Scripts/configure-Xcode-to-build-iOS-Simulator-command-line-tool:57
> +    return if -d $file || $file !~ /\.xcspec$/;

Do we care about operating on symlinks?  An alternative approach that only
operates on real files is:

    return if ! -f $file || $file !~ /\.xcspec$/;

> Tools/Scripts/configure-Xcode-to-build-iOS-Simulator-command-line-tool:94
> +

Please add an 'exit 0;' here to show when the main part of the script ends.