[webkit-reviews] review denied: [Bug 136384] Crashes in IPC code under VisitedLinkProvider::pendingVisitedLinksTimerFired : [Attachment 237370] proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 136384: Crashes in IPC code under
VisitedLinkProvider::pendingVisitedLinksTimerFired
https://bugs.webkit.org/show_bug.cgi?id=136384

Attachment 237370: proposed patch
https://bugs.webkit.org/attachment.cgi?id=237370&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237370&action=review


> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:54
> +static HashSet<VisitedLinkProvider*>& allVisitedLinkProviders()
> +{
> +    ASSERT(RunLoop::isMain());
> +    static NeverDestroyed<HashSet<VisitedLinkProvider*>> providers;
> +    return providers;

I don't think these should be globals.	Instead, the WebProcessProxy should
store this.