[webkit-reviews] review granted: [Bug 136259] Prevent decoded images from being destroyed when they're in use. : [Attachment 237320] updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daewoong Jang
<daewoong.jang at navercorp.com>'s request for review:
Bug 136259: Prevent decoded images from being destroyed when they're in use.
https://bugs.webkit.org/show_bug.cgi?id=136259

Attachment 237320: updated patch
https://bugs.webkit.org/attachment.cgi?id=237320&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
We should not give up on trying to cover this with tests. The reason we have
the “add a test whenever we fix a bug” policy is so we don’t keep breaking the
same things over and over again. I understand that it’s much harder to make a
test here than it is to simply undo the regression we caused. But the
discussion we’ve had so far about why it’s hard to make a test have not been
satisfactory -- it’s simply logically incorrect to say that because Pratik
didn’t add a test when he refactored and broke this by mistake that we don’t
need a test when we fix it. I know it’s frustrating, but when we make a mistake
like that it is our policy to add coverage after the fact so we don’t make the
same mistake again. So it’s not the person who made the mistake, but the rest
of us after the fact who have to try to figure out how to add test coverage.

I’m going to reluctantly say review+ here but I would like someone to make a
test.