[webkit-reviews] review granted: [Bug 136356] Occasional thread-safety-related crashes on the ServicesController queue : [Attachment 237330] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 136356: Occasional thread-safety-related crashes on the ServicesController
queue
https://bugs.webkit.org/show_bug.cgi?id=136356

Attachment 237330: patch
https://bugs.webkit.org/attachment.cgi?id=237330&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237330&action=review


> Source/WebKit2/UIProcess/mac/ServicesController.mm:109
> +    NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer |
NSSharingServiceMaskEditor;

I don’t see why this variable is needed.

> Source/WebKit2/UIProcess/mac/ServicesController.mm:110
> +    return [[NSSharingService sharingServicesForItems:items
mask:serviceMask] count];

You can use .count notation here!