[webkit-reviews] review denied: [Bug 135830] Promise reactions in the Inspector page do not run when the debugger is paused on the inspected page : [Attachment 237317] Proposed fix (rebased)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 11:42:47 PDT 2014


Timothy Hatcher <timothy at apple.com> has denied Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135830: Promise reactions in the Inspector page do not run when the
debugger is paused on the inspected page
https://bugs.webkit.org/show_bug.cgi?id=135830

Attachment 237317: Proposed fix (rebased)
https://bugs.webkit.org/attachment.cgi?id=237317&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237317&action=review


> Source/WebInspectorUI/UserInterface/External/RSVP/LICENSE:1
> +Copyright (c) 2014 Yehuda Katz, Tom Dale, Stefan Penner and contributors

I'll file an internal OSS request for RSVP.

> Source/WebInspectorUI/UserInterface/Main.html:145
> +    <script src="External/RSVP/rsvp.js"></script>

copy-user-interface-resources.pl needs modified to do the right thing when
resources are combined. You can copy how Esprima.js is handled.


More information about the webkit-reviews mailing list