[webkit-reviews] review denied: [Bug 124601] Cannot build TestWebKitAPI target from within Xcode : [Attachment 217335] v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 10:30:46 PDT 2014

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 124601: Cannot build TestWebKitAPI target from within Xcode

Attachment 217335: v1

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
The WebKit[1|Legacy] change seems fine, and the TestWebKitAPI change seems
fine, but the WebKit2 change should probably be fixed a different way.	Do you
know which headers WebKit2 depends on from WebKit[1|Legacy]?

r- because I think WebKit.framework has been renamed to WebKitLegacy.framework,
and WebKit2.framework has been renamed to WebKit.framework, so the patch has
likely bit-rotted.

More information about the webkit-reviews mailing list