[webkit-reviews] review granted: [Bug 93361] DFG should compute immediate dominators using the O(n log n) form of Lengauer and Tarjan's "A Fast Algorithm for Finding Dominators in a Flowgraph" : [Attachment 237285] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenb at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 93361: DFG should compute immediate dominators using the O(n log n) form of
Lengauer and Tarjan's "A Fast Algorithm for Finding Dominators in a Flowgraph"
https://bugs.webkit.org/show_bug.cgi?id=93361

Attachment 237285: the patch
https://bugs.webkit.org/attachment.cgi?id=237285&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenb at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237285&action=review


r=me with comments.

> Source/JavaScriptCore/dfg/DFGDominators.cpp:114
> +	       // We're initially push with successorIndex = 0 regardless of
whether or not we have

s/We're initially/We initially/