[webkit-reviews] review denied: [Bug 133571] [JavaScriptCore] Fix FTL on platform EFL. : [Attachment 237301] Proposed patch based on previous comments and update to ToT.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 28 07:45:18 PDT 2014
Filip Pizlo <fpizlo at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 133571: [JavaScriptCore] Fix FTL on platform EFL.
https://bugs.webkit.org/show_bug.cgi?id=133571
Attachment 237301: Proposed patch based on previous comments and update to ToT.
https://bugs.webkit.org/attachment.cgi?id=237301&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237301&action=review
> Source/JavaScriptCore/ftl/FTLState.h:80
> + void* section;
It's wrong to change the name of this field to just "section". That could mean
any kind if section. You're using it for the section that has unwind data. You
should pick a name that reflects this.
More information about the webkit-reviews
mailing list