[webkit-reviews] review granted: [Bug 136308] WebKit2 swipe gesture should report the position of the snapshot to the client : [Attachment 237248] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 27 17:39:20 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 136308: WebKit2 swipe gesture should report the position of the snapshot to
the client
https://bugs.webkit.org/show_bug.cgi?id=136308

Attachment 237248: patch
https://bugs.webkit.org/attachment.cgi?id=237248&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237248&action=review


> Source/WebKit2/UIProcess/PageClient.h:234
> +    virtual CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *) =
0;

const?

> Source/WebKit2/UIProcess/WebPageProxy.h:512
> +    CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *);

const?

> Source/WebKit2/UIProcess/mac/PageClientImpl.h:112
> +    CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *layer);

const?


More information about the webkit-reviews mailing list