[webkit-reviews] review granted: [Bug 136319] Subpixel layout: Rename LayoutRect's device pixel snapping functions. : [Attachment 237267] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 136319: Subpixel layout: Rename LayoutRect's device pixel snapping
functions.
https://bugs.webkit.org/show_bug.cgi?id=136319

Attachment 237267: Patch
https://bugs.webkit.org/attachment.cgi?id=237267&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237267&action=review


> Source/WebCore/platform/graphics/LayoutRect.h:205
> +WEBCORE_EXPORT IntRect enclosingIntRect(const LayoutRect&);
> +WEBCORE_EXPORT LayoutRect enclosingLayoutRect(const FloatRect&);

Do we want these to be inlined? if so, we should make an exported function that
wraps them.

> Source/WebCore/platform/graphics/LayoutRect.h:227
> +FloatRect enclosingRectToDevicePixels(const LayoutRect&, float
pixelSnappingFactor);

encloseRectToDevicePixels?