[webkit-reviews] review granted: [Bug 136313] ASSERTION FAILED: from.isCell() && from.asCell()->JSCell::inherits(std::remove_pointer<To>::type::info()) in JSC::jsCast(JSC::JSValue) [with To = JSC::JSScope*] : [Attachment 237257] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 27 15:25:50 PDT 2014


Michael Saboff <msaboff at apple.com> has granted	review:
Bug 136313: ASSERTION FAILED: from.isCell() &&
from.asCell()->JSCell::inherits(std::remove_pointer<To>::type::info()) in
JSC::jsCast(JSC::JSValue) [with To = JSC::JSScope*]
https://bugs.webkit.org/show_bug.cgi?id=136313

Attachment 237257: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=237257&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237257&action=review


r=me

> Source/JavaScriptCore/jit/JITOperations.cpp:614
> +    execCallee->setCallerFrame(static_cast<CallFrame*>(exec));

The static_cast is not needed.	CallFrame is a typedef of ExecState.


More information about the webkit-reviews mailing list