[webkit-reviews] review denied: [Bug 136239] Building for native inlining broken on root build : [Attachment 237171] Fixes building for native inlining.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 27 14:10:51 PDT 2014


Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 136239: Building for native inlining broken on root build
https://bugs.webkit.org/show_bug.cgi?id=136239

Attachment 237171: Fixes building for native inlining.
https://bugs.webkit.org/attachment.cgi?id=237171&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I don't think we should make it convention that everything is either exported
or ALWAYS_INLINE.  We should have a solution in LLVM that allows us to call
static functions from the JIT.


More information about the webkit-reviews mailing list