[webkit-reviews] review granted: [Bug 136268] Web Inspector: Layout issues for popover on not legacy OS : [Attachment 237236] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 27 12:20:31 PDT 2014
Timothy Hatcher <timothy at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 136268: Web Inspector: Layout issues for popover on not legacy OS
https://bugs.webkit.org/show_bug.cgi?id=136268
Attachment 237236: patch
https://bugs.webkit.org/attachment.cgi?id=237236&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237236&action=review
> Source/WebInspectorUI/UserInterface/Views/Popover.js:199
> + const titleBarOffset = (WebInspector.Platform.name === "mac" &&
!WebInspector.Platform.isLegacyMacOS ? 22 : 0);
Could be written as:
const titleBarOffset = WebInspector.Platform.isLegacyMacOS ? 0 : 22;
Drop the () too.
More information about the webkit-reviews
mailing list