[webkit-reviews] review denied: [Bug 136268] Web Inspector: Layout issues for popover on not legacy OS : [Attachment 237235] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Saam Barati
<sbarati at apple.com>'s request for review:
Bug 136268: Web Inspector: Layout issues for popover on not legacy OS
https://bugs.webkit.org/show_bug.cgi?id=136268

Attachment 237235: patch
https://bugs.webkit.org/attachment.cgi?id=237235&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237235&action=review


> Source/WebInspectorUI/UserInterface/Views/Popover.js:200
> +	   var padding = (WebInspector.Platform.isLegacyMacOS ? 0 : 22);

The condition needs to check if this is mac:

    var shouldAddTopWindowPadding = WebInspector.Platform.name === "mac" &&
!WebInspector.Platform.isLegacyMacOS;

Otherwise windows and linux ports would add this 22px of padding unnecessarily.


And maybe a better word is "offset" instead of padding.