[webkit-reviews] review granted: [Bug 136196] build.webkit.org/dashboard: Add a metrics page with overall bot performance results : [Attachment 237211] proposed patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 136196: build.webkit.org/dashboard: Add a metrics page with overall bot
performance results
https://bugs.webkit.org/show_bug.cgi?id=136196

Attachment 237211: proposed patch
https://bugs.webkit.org/attachment.cgi?id=237211&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237211&action=review


Looks great!

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/M
etricsMain.js:51
> +	   if (queue.builder) {
> +	       categoryName = "builders";
> +	   } else if (queue.tester) {
> +	       categoryName = queue.testCategory;
> +	   } else {

Can drop the braces.