[webkit-reviews] review granted: [Bug 136281] build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time : [Attachment 237205] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 26 23:06:52 PDT 2014


Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 136281: build.webkit.org/dashboard: Poor performance when there are broken
builds at initial load time
https://bugs.webkit.org/show_bug.cgi?id=136281

Attachment 237205: proposed fix
https://bugs.webkit.org/attachment.cgi?id=237205&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237205&action=review


> Tools/ChangeLog:10
> +	   the iteration is already beaing loaded.

s/beaing/being/

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbotBuilderQueueView.js:111
> +		       queue.loadMoreHistoricIterations();

historic (adj.): "famous or important in history, or potentially so"

I think you want 'historical'. English is weird.


More information about the webkit-reviews mailing list