[webkit-reviews] review granted: [Bug 136098] Canvas direction should reflect change in dir attribute and also across save/restore operations : [Attachment 237145] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Vivek Galatage <vivekg at webkit.org>'s
request for review:
Bug 136098: Canvas direction should reflect change in dir attribute and also
across save/restore operations
https://bugs.webkit.org/show_bug.cgi?id=136098

Attachment 237145: Patch
https://bugs.webkit.org/attachment.cgi?id=237145&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237145&action=review


OK, lets land this one.

> LayoutTests/fast/canvas/canvas-direction.html:220
> +				     [{ text: 'Left-to-Right text', direction:
'ltr' },
> +				      { text: 'Right-to-Left text', direction:
'rtl' },
> +				      { text: 'Right-to-Left text', direction:
'rtl' },
> +				      { text: 'Left-to-Right text', direction:
'ltr' },
> +				      { text: 'Right-to-Left text', direction:
'rtl' },
> +				      { text: 'Right-to-Left text', direction:
'rtl' }]);

We don’t do this kind of indenting in the WebKit. We never want to have to
reindent if we rename something.