[webkit-reviews] review granted: [Bug 136189] Add WebKit SPI to control the navigator.standalone property : [Attachment 237180] Patch v2

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Matt Lilek (pewtermoose)
<mlilek at apple.com>'s request for review:
Bug 136189: Add WebKit SPI to control the navigator.standalone property
https://bugs.webkit.org/show_bug.cgi?id=136189

Attachment 237180: Patch v2
https://bugs.webkit.org/attachment.cgi?id=237180&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237180&action=review


r=me

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:31
> +#import "Test.h"

This should come before the <>-style imports.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:33
> +#if WK_API_ENABLED

This should come after #import "config.h" but before the other imports.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:40
> +TEST(WebKit2, DefaultWKPreferences)
> +{
> +    RetainPtr<WKPreferences> preferences = adoptNS([[WKPreferences alloc]
init]);
> +
> +    EXPECT_FALSE([preferences _isStandalone]);
> +}

You should also test setting the property (e.g. [preferences
_setStandalone:YES]; EXPECT_TRUE([preferences _isStandalone];).