[webkit-reviews] review granted: [Bug 136239] Building for native inlining broken on root build : [Attachment 237170] Fixes building for native inlining.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 26 13:45:33 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Matthew Mirman
<mmirman at apple.com>'s request for review:
Bug 136239: Building for native inlining broken on root build
https://bugs.webkit.org/show_bug.cgi?id=136239

Attachment 237170: Fixes building for native inlining.
https://bugs.webkit.org/attachment.cgi?id=237170&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237170&action=review


r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4439
>	   if (linkModules(m_ftlState.module, module, LLVMLinkerDestroySource,
&outMsg)) {
> -	       if (Options::verboseFTLFailure())
> +	       // if (verboseCompilationEnabled())

Revert.


More information about the webkit-reviews mailing list