[webkit-reviews] review denied: [Bug 136264] Subpixel layout: Rename snapSizeToPixel to snapSizeToInt. : [Attachment 237166] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 136264: Subpixel layout: Rename snapSizeToPixel to snapSizeToInt.
https://bugs.webkit.org/show_bug.cgi?id=136264

Attachment 237166: Patch
https://bugs.webkit.org/attachment.cgi?id=237166&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237166&action=review


r- because snapSize with a local point is meaningless.

> Source/WebCore/platform/LayoutUnit.h:919
> +inline int snapSizeToInt(LayoutUnit size, LayoutUnit location)

Three things make me sad about this. "snap" outside of pixel snapping, "size"
which is not a LayoutSize and "location" that is not a layout point.

Can we just remove this and down the work inside LayoutRect?