[webkit-reviews] review denied: [Bug 136262] Remove UNUSED_PARAM macros from ServicesOverlayController.mm : [Attachment 237164] Patch to remove the two UNUSED_PARAM() macros

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Dana Burkart
<dburkart at apple.com>'s request for review:
Bug 136262: Remove UNUSED_PARAM macros from ServicesOverlayController.mm
https://bugs.webkit.org/show_bug.cgi?id=136262

Attachment 237164: Patch to remove the two UNUSED_PARAM() macros
https://bugs.webkit.org/attachment.cgi?id=237164&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237164&action=review


Please fix the UNUSED_PARAM() statements in
ServicesOverlayController::selectionRectsDidChange().  Thanks!

> Source/WebKit2/ChangeLog:3
> +	   The UNUSED_PARAM macros in ServicesOverlayController.mm are causing
ASan failures.

Maybe say:  "causing ASan build failures."

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394
> -#else
> -    UNUSED_PARAM(rects);

This one actually needs to add two UNUSED_PARAM() statements for new arguments
added to the method at some point:

    UNUSED_PARAM(rects);
    UNUSED_PARAM(gapRects);
    UNUSED_PARAM(isTextOnly);