[webkit-reviews] review granted: [Bug 136253] Subpixel layout: Remove float to LayoutUnit ceil/round function wrappers. : [Attachment 237160] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 136253: Subpixel layout: Remove float to LayoutUnit ceil/round function
wrappers.
https://bugs.webkit.org/show_bug.cgi?id=136253

Attachment 237160: Patch
https://bugs.webkit.org/attachment.cgi?id=237160&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237160&action=review


> Source/WebCore/rendering/RenderBlock.cpp:2902
> +    preferredWidth = std::max(LayoutUnit::fromFloatCeil(result),
preferredWidth);

You lost some of the comment here, which I think is useful to explain why this
code uses ceil.