[webkit-reviews] review denied: [Bug 136253] Subpixel layout: Make LayoutUnit ceil/round operations more explicit. : [Attachment 237156] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 136253: Subpixel layout: Make LayoutUnit ceil/round operations more
explicit.
https://bugs.webkit.org/show_bug.cgi?id=136253

Attachment 237156: Patch
https://bugs.webkit.org/attachment.cgi?id=237156&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237156&action=review


> Source/WebCore/platform/LayoutUnit.h:926
> +// When this occurs while accumulating converted LayoutUnit values, we can
wind up with a result smaller than expected.

That doesn't explain the ceil though. This comment is pretty confusing. The
caller really needs to know whether ceiling or flooring is appropriate for
them.

> Source/WebCore/platform/LayoutUnit.h:927
> +inline LayoutUnit ceilFloatForSubPixelLayout(float value)

I don't think the "ForSubPixelLayout" adds anything. I think the name
"ceiledLayoutUnit" is as good.