[webkit-reviews] review granted: [Bug 136220] [GTK] Add WaylandSurface : [Attachment 237140] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 136220: [GTK] Add WaylandSurface
https://bugs.webkit.org/show_bug.cgi?id=136220

Attachment 237140: Patch
https://bugs.webkit.org/attachment.cgi?id=237140&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237140&action=review


Looks good. Glad to see this moving forward. Please make these few small
changes before landing.

> Source/WebCore/PlatformGTK.cmake:438
> +	   platform/graphics/wayland/WaylandSurface.cpp
>	   ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandClientProtocol.c

The WebKit CMake style specifies that there should be a blank line between
files in different directories.

> Source/WebCore/platform/graphics/wayland/WaylandSurface.h:49
> +    void resize(int, int);

You should specify the variable names here or pass IntSize.

> Source/WebCore/platform/graphics/wayland/WaylandSurface.h:56
> +    static const struct wl_callback_listener m_frameListener;

This doesn't need to be a static member of the class. It's enough to make it
static in the source file.

> Source/WebCore/platform/graphics/wayland/WaylandSurface.h:57
> +    static void frameCallback(void*, struct wl_callback*, uint32_t);

Ditto.