[webkit-reviews] review granted: [Bug 136245] [EFL] Build break using clang : [Attachment 237137] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 136245: [EFL] Build break using clang
https://bugs.webkit.org/show_bug.cgi?id=136245

Attachment 237137: Patch
https://bugs.webkit.org/attachment.cgi?id=237137&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237137&action=review


Please fix my comment.

> Source/WebCore/css/ViewportStyleResolver.cpp:37
> +#include "NodeRenderStyle.h"

I believe this include won't harmful on other ports.

> Source/WebKit2/PlatformEfl.cmake:457
> +    -DGTEST_HAS_RTTI=0

GTK port also disabled this macro.

> Source/cmake/OptionsEfl.cmake:11
> +# Disable WERROR in clang build because of many warnings.

Add FIXME: prefix.