[webkit-reviews] review denied: [Bug 136082] Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API : [Attachment 237124] Fixed refcounting approach

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 136082: Replace use of WKCopyCFLocalizationPreferredName with NSLocale
public API
https://bugs.webkit.org/show_bug.cgi?id=136082

Attachment 237124: Fixed refcounting approach
https://bugs.webkit.org/attachment.cgi?id=237124&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237124&action=review


> Source/WebCore/platform/mac/WebCoreNSStringExtras.mm:158
> +    return [CFBridgingRElease(code.leafRef()) autorelease];

This won’t compile. What you want is:

    return CFBridgingRelease(code.leakRef());

The code here still has an extra autorelease, and it has two typos.