[webkit-reviews] review granted: [Bug 136237] Make build.webkit.org/dashboard work with changeset_show_files=location : [Attachment 237111] proposed patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 136237: Make build.webkit.org/dashboard work with
changeset_show_files=location
https://bugs.webkit.org/show_bug.cgi?id=136237

Attachment 237111: proposed patch
https://bugs.webkit.org/attachment.cgi?id=237111&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237111&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/T
rac.js:106
> +	       // changes element may or may not be present depending on server
configuration (preferably "changeset_show_files=location");

is 'preferably' the right word here?

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/T
rac.js:137
> +		   result.tag = location.substr(5, location.indexOf("/", 5) -
5);

This is unfortunate but I don't know how to do it better.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/T
rac.js:142
> +	       else if (location.startsWith("trunk/") || location === "trunk")

I don't think you need this ===