[webkit-reviews] review granted: [Bug 136132] [GStreamer] ASSERT failure in WebKitWebSource in StreamingClient : [Attachment 237008] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 136132: [GStreamer] ASSERT failure in WebKitWebSource in StreamingClient
https://bugs.webkit.org/show_bug.cgi?id=136132

Attachment 237008: Patch
https://bugs.webkit.org/attachment.cgi?id=237008&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237008&action=review


Not setting cq+ yet, is the crack word a typo in the ChangeLog? :)

> Source/WebCore/ChangeLog:8
> +	   don't construct this ourselves, I assume this is happening in
Playbin.

Yes it happens at least in the HLS case when the demuxer creates a new
webkitsrc element using gst_element_make_from_uri() to download a new fragment.
I suppose it's similar for DASH.

> Source/WebCore/ChangeLog:12
> +	   This should work, but actually causes the page to either lock up or
crack (different

crack? :)