[webkit-reviews] review denied: [Bug 136172] get rid of WebCore.exp.in : [Attachment 237002] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 24 11:48:21 PDT 2014

Darin Adler <darin at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 136172: get rid of WebCore.exp.in

Attachment 237002: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
This needs to be landed in pieces.

1) Land all the parts of this that add in or remove WEBCORE_EXPORT. Except
possibly for the ones in npruntime_impl.h since that is an imported header file
that we generally wish not to modify. Maybe that’s not a big deal any more, but
that feels like an open question to me at this time.

2) Construct the smallest possible “throw the switch” patch, *not* the full
“clean up all the remnants” version. Run the nm command before and after this
patch to make a diff. If the diff is acceptable, then land that patch.

3) Follow up with the cleanup patch that removes all the remnants of the old
system. This step includes deleting the actual export files, and even the
sort-export-file script and the code we recently added to check-webkit-style to
invoke it.

Someone should come up with another patch for the next piece of (1). As long as
it only adds a macro that has no effect, I think it can be a huge patch and we
need only review it to make sure we don’t accidentally include other changes.

More information about the webkit-reviews mailing list