[webkit-reviews] review granted: [Bug 136195] build.webkit.org/dashboard unnecessarily loads results of hidden queues : [Attachment 237034] proposed fix

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 136195: build.webkit.org/dashboard unnecessarily loads results of hidden
queues
https://bugs.webkit.org/show_bug.cgi?id=136195

Attachment 237034: proposed fix
https://bugs.webkit.org/attachment.cgi?id=237034&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237034&action=review


> Tools/ChangeLog:13
> +	   are triggered by views, so it only makes sens to do the same for
initial update.

sens*e*

for *the* initial update?

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Q
ueueView.js:35
> +    setTimeout(function() { this._updateHiddenState(); }.bind(this), 0);

Should you do this more like the next line does? Is there a reason for the
extra function?