[webkit-reviews] review granted: [Bug 136183] WebKit and WebKit2: Use ASCIILiteral where possible : [Attachment 237010] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 136183: WebKit and WebKit2: Use ASCIILiteral where possible
https://bugs.webkit.org/show_bug.cgi?id=136183

Attachment 237010: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=237010&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237010&action=review


> Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp:84
> -	   *setting =
static_cast<bool>(CFBooleanGetValue(static_cast<CFBooleanRef>(value.get()))) ?
"true" : "false";
> +	   *setting =
static_cast<bool>(CFBooleanGetValue(static_cast<CFBooleanRef>(value.get()))) ?
ASCIILiteral("true") : ASCIILiteral("false");