[webkit-reviews] review granted: [Bug 136184] Remove unnecessary WTFString creation in Dictionary getter : [Attachment 237013] [PATCH] Proposed Fix - should apply

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 22 17:12:37 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 136184: Remove unnecessary WTFString creation in Dictionary getter
https://bugs.webkit.org/show_bug.cgi?id=136184

Attachment 237013: [PATCH] Proposed Fix - should apply
https://bugs.webkit.org/attachment.cgi?id=237013&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237013&action=review


> Source/WebCore/bindings/js/JSDictionary.cpp:272
> +    if (tryGetProperty(propertyName, value) != PropertyFound ||
value.isUndefinedOrNull())

lol!


More information about the webkit-reviews mailing list