[webkit-reviews] review granted: [Bug 136149] ASSERTION FAILED: !trackSizes.isEmpty() in WebCore::createGridTrackList : [Attachment 236982] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 136149: ASSERTION FAILED: !trackSizes.isEmpty() in
WebCore::createGridTrackList
https://bugs.webkit.org/show_bug.cgi?id=136149

Attachment 236982: Patch
https://bugs.webkit.org/attachment.cgi?id=236982&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236982&action=review


> Source/WebCore/css/CSSParser.cpp:5278
> +    bool seenTrackSize = false;

“seen track size” is not good grammar. It would be better to name this “saw
track size” or “track size was seen” or something else that’s a grammatically
correct predicate.