[webkit-reviews] review granted: [Bug 136136] Implement paint flashing via GraphicsLayers in the WK2 inspector overlay : [Attachment 236943] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 136136: Implement paint flashing via GraphicsLayers in the WK2 inspector
overlay
https://bugs.webkit.org/show_bug.cgi?id=136136

Attachment 236943: Patch
https://bugs.webkit.org/attachment.cgi?id=236943&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236943&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp:54
> +    virtual void notifyAnimationEnded(const GraphicsLayer* layer, const
String&)

This should have override.

> Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h:93
> +    HashSet<WebCore::GraphicsLayer*> m_paintRectLayers;

It might be worth noting that this should use a
HashSet<std::unique_ptr<WebCore::GraphicsLayer>> but can't due to HashSet
issues (and point to a bug).