[webkit-reviews] review granted: [Bug 136138] Implement paint flashing in the WK1 InspectorOverlay page : [Attachment 236944] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 136138: Implement paint flashing in the WK1 InspectorOverlay page
https://bugs.webkit.org/show_bug.cgi?id=136138

Attachment 236944: Patch
https://bugs.webkit.org/attachment.cgi?id=236944&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236944&action=review


> Source/WebCore/inspector/InspectorOverlay.cpp:494
> +    double removeTime = currentTime() + 0.25;

Wat? Crono?

> Source/WebCore/inspector/InspectorOverlay.cpp:498
> +	   m_paintRectUpdateTimer.startRepeating(0.016);

Wat?

> Source/WebCore/inspector/InspectorOverlayPage.js:210
> +    // Don't get the context until we need to paint, to avoid backing store
allocation.

This comment is weirdly paragraphed?

> Source/WebCore/inspector/InspectorOverlayPage.js:216
> +    // clear paint rects?

This is weird? At least add a FIXME: and capitalize the C in clear.

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:107
> +#if PLATFORM(IOS)
> +    bool m_showingPaintRects;
> +#endif
>  };

This is unused. You should remove it.